Skip to content

Use challenge api#41

Merged
z2trillion merged 8 commits into
feat/refactor_noncefrom
feat/rlc_randomness
May 30, 2023
Merged

Use challenge api#41
z2trillion merged 8 commits into
feat/refactor_noncefrom
feat/rlc_randomness

Conversation

@z2trillion

Copy link
Copy Markdown
Contributor

No description provided.

@z2trillion z2trillion requested review from noel2004 and silathdiir May 29, 2023 23:29
@z2trillion z2trillion marked this pull request as ready for review May 29, 2023 23:29
@z2trillion z2trillion requested a review from lispc May 30, 2023 02:21
@lispc

lispc commented May 30, 2023

Copy link
Copy Markdown
Contributor

many columns (like root and value in mpt table) are RLCed, and should be second phase columns.
But i grep the code base with "advice_column_in", i found nothing? Where are these columns marked as second phase?

(if we grep "advice_column_in" inside zkevm-circuits code base, you will find many)

@z2trillion

Copy link
Copy Markdown
Contributor Author

many columns (like root and value in mpt table) are RLCed, and should be second phase columns. But i grep the code base with "advice_column_in", i found nothing? Where are these columns marked as second phase?

(if we grep "advice_column_in" inside zkevm-circuits code base, you will find many)

There are not any at the moment and I am trying to figure out why the phase-check is not causing a panic.

@z2trillion z2trillion merged commit f6e1782 into feat/refactor_nonce May 30, 2023
@z2trillion z2trillion deleted the feat/rlc_randomness branch May 30, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants