Skip to content

Conversation

@Thegaram
Copy link

@Thegaram Thegaram commented Sep 8, 2023

1. Purpose or design rationale of this PR

Errors:

Error: rollup/circuitcapacitychecker/impl.go:150:68: undefined: unit64
Error: rollup/circuitcapacitychecker/impl.go:162:5: undefined: err
Error: rollup/circuitcapacitychecker/impl.go:162:66: undefined: err
Error: rollup/circuitcapacitychecker/impl.go:163:78: undefined: err
Error: rollup/circuitcapacitychecker/impl.go:171:25: undefined: unit64

Fixes:

- func (ccc *CircuitCapacityChecker) CheckTxNum(expected int) (bool, unit64, error) {
+ func (ccc *CircuitCapacityChecker) CheckTxNum(expected int) (bool, uint64, error) {
- if err = json.Unmarshal([]byte(C.GoString(rawResult)), result); err != nil {
+ if err := json.Unmarshal([]byte(C.GoString(rawResult)), result); err != nil {

Additional fix: Return detailed error instead of ErrUnknown.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@Thegaram
Copy link
Author

Thegaram commented Sep 8, 2023

Tested on a VM, still getting this error:

# github.com/scroll-tech/go-ethereum/rollup/circuitcapacitychecker
/usr/bin/ld: $WORK/b277/_x002.o: in function `_cgo_1c072de711fe_Cfunc_get_tx_num':
/tmp/go-build/cgo-gcc-prolog:102: undefined reference to `get_tx_num'
collect2: error: ld returned 1 exit status

georgehao
georgehao previously approved these changes Sep 8, 2023
@Thegaram Thegaram marked this pull request as draft September 8, 2023 13:18
@Thegaram Thegaram marked this pull request as ready for review September 8, 2023 13:29
silathdiir
silathdiir previously approved these changes Sep 8, 2023
Copy link

@silathdiir silathdiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for not building after fixing, thanks.

@silathdiir silathdiir requested a review from georgehao September 8, 2023 13:43
@scroll-dev scroll-dev merged commit 1d824f4 into develop Sep 8, 2023
@scroll-dev scroll-dev deleted the fix-typo-in-ccc branch September 8, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants