Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of these aren't states or territories - they're entirely different countries #118

Closed
petebarnettio opened this issue Feb 9, 2022 · 3 comments · Fixed by #119
Closed
Assignees
Labels
bug Something isn't working

Comments

@petebarnettio
Copy link

The following are countries unaffiliated with the United States (via state, incorporated territory, or unincorporated territory) and should be removed. They are part of Compacts of Free Association, but are separate entities entirely, maintaining embassies in the United States. To have them under a list of "typed-usa-states" is extremely misleading.

  • Federated States of Micronesia
  • Marshall Islands
  • Palau
@scriptex
Copy link
Owner

Thanks for the input @petebarnettio . Do you think you will have the time to remove them by submitting a PR?

@scriptex scriptex self-assigned this Feb 14, 2022
@scriptex scriptex added the bug Something isn't working label Feb 14, 2022
@scriptex scriptex linked a pull request Feb 14, 2022 that will close this issue
@scriptex
Copy link
Owner

@petebarnettio I've took the time to update this. The new version (2.1.0) is available on Github and on NPM.

Thank you for your contribution!

@petebarnettio
Copy link
Author

Great work, thanks @scriptex!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants