Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accent characters menu option from iPads #477

Closed
2 tasks done
andrewtavis opened this issue Jul 26, 2024 · 3 comments
Closed
2 tasks done

Remove accent characters menu option from iPads #477

andrewtavis opened this issue Jul 26, 2024 · 3 comments
Assignees
Labels
-next release- Included in the next release bug Something isn't working help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Jul 26, 2024

Terms

Behavior

An issue that we have right now is that the disable accent characters option is available for iPads when it shouldn't be. Enabling this option crashes the keyboard, so it should be removed as this option doesn't add much for an iPad user (likely wouldn't be used).

One consideration though is that the Layout section of the menu would then be empty. We thus should conditionally render the settings section if there is an option present, or remove the entire section if it's not needed :)

Happy to support or work on this!

Device type

iPad

Versions

v3.0 and current main

@andrewtavis andrewtavis added bug Something isn't working help wanted Extra attention is needed labels Jul 26, 2024
@andrewtavis andrewtavis added the -next release- Included in the next release label Jul 26, 2024
@fabulouiOS-monk
Copy link
Collaborator

@andrewtavis, you can assign me this now. I will be in touch with you regarding the details. Thank you!

@andrewtavis
Copy link
Member Author

Thanks so much for picking this up, @fabulouiOS-monk! 🚀

@andrewtavis
Copy link
Member Author

Closed by #480! 🎉 Thanks so much for the quick work here, @fabulouiOS-monk! 🚀

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-next release- Included in the next release bug Something isn't working help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants