Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign expanded iPad layouts for devices that are wide enough #352

Closed
2 tasks done
andrewtavis opened this issue Aug 11, 2023 · 3 comments
Closed
2 tasks done

Assign expanded iPad layouts for devices that are wide enough #352

andrewtavis opened this issue Aug 11, 2023 · 3 comments
Assignees
Labels
-priority- High priority design Relates to UX/UI designs feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

This issue would be to assign the keyboard layouts that were made in #33 to iPads that have wide enough screens. Ideally there would also be some work done to space the keys appropriately, but the team can also assist with this 😊

Contribution

Happy to work on this myself or assist someone who has interest in working on it!

@andrewtavis andrewtavis added the design Relates to UX/UI designs label Aug 11, 2023
@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed -priority- High priority labels Aug 11, 2023
@henrikth93
Copy link
Member

I am interested in doing this

@andrewtavis
Copy link
Member Author

Sounds great, @henrikth93! Glad to have some help on this 😊 Assigning you now, and please let us know if you need some assistance!

@andrewtavis
Copy link
Member Author

andrewtavis commented Oct 16, 2023

This issue was closed by 2b544e0 😊😊 Here's a quick summary of what I did, @henrikth93:

  • Basic formatting and fixing the comments
  • The condition to check if a keyboard should be expanded was just outside of isFirstKeyboardLoad, so I put it above conditionallyShowTopNumbersRow and a few other baseline functions
  • The check for the home button wasn't working, so it's now just checking for a width > 768
    • I feel like we should do the menu option for this before release so the person has the option to always turn it off or on, and in this way it should generally work :)
  • I like how you were checking for the symbolKeys for widths and changed it so that we always do this instead of the number keys that might not be there 👍👍
  • I added StackViewNum into some of the steps that are adding keys (this is what was causing the top row to not show up as it never was having the keys added to it)
  • Unrelated bug fix for how the menu option to add a period and comma to the letter keys was being implemented as this was actually replacing the bottom row in cases when it shouldn't have been 😊
  • Random minor fixes that I picked up along the way :)

Again very sorry for the wait on this! And thank you so much for all the work here!

Let me know if you have interest in working on #362. I'm also going to be making an issue now to add the functionality into keys like the tab key and other new ones that we have on the expanded layouts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority design Relates to UX/UI designs feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants