Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large embedded <image>s are shrunk #58

Open
towerofnix opened this issue Nov 5, 2018 · 0 comments
Open

Large embedded <image>s are shrunk #58

towerofnix opened this issue Nov 5, 2018 · 0 comments
Assignees
@fsih
Labels
bug Something isn't working needs-triage
Milestone
Backlog

Comments

@towerofnix
Copy link

towerofnix commented Nov 5, 2018 •
edited
Loading

Expected Behavior

The embedded image should be the correct (original) size:

A crop of the Wings of Fire map of Pyrrhia; some is cut off around the edges of the 2.0 paint editor

Actual Behavior

The embedded image is shrunk:

The 3.0 paint editor, showing that the entire map embedded previously, shrunk to fit about 75% of the stage size

Steps to Reproduce

  • Create an SVG embedding a large <image> in it. (This is a niche trick for embedding bitmap images that are larger than the stage.)
  • Compare the appearance of the SVG in Scratch 2.0 and 3.0.

I've created a demo project here (3.0, 2.0).

I spotted this issue while testing this project in 3.0: https://scratch.mit.edu/projects/116498519/

Operating System and Browser

Chrome 70.0.3538.77 and Firefox 63.0.1, macOS 10.13.6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsih fsih

Labels
bug Something isn't working needs-triage
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Properly handle Scratch 2.0's <image> behavior... but at what cost? adroitwhiz/scratch-svg-renderer
3 participants
@thisandagain @fsih @towerofnix