Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests do not cover fonts #278

Open
cwillisf opened this issue May 14, 2021 · 0 comments
Open

tests do not cover fonts #278

cwillisf opened this issue May 14, 2021 · 0 comments

Comments

@cwillisf
Copy link
Contributor

Expected Behavior

Automated tests should cover all major aspects of the code in this module

Actual Behavior

The code in font-inliner.js is not covered in any test. This means if we change the API for scratch-render-fonts (as we did recently) in such a way that font-inliner.js no longer works, the tests will still pass and not call attention to the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant