Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer events are not bound correctly #27

Open
paulkaplan opened this issue Sep 5, 2019 · 0 comments · May be fixed by #37
Open

Pointer events are not bound correctly #27

paulkaplan opened this issue Sep 5, 2019 · 0 comments · May be fixed by #37
Labels

Comments

@paulkaplan
Copy link

There is a bug in the code which decides which events to bind (pointer, touch, mouse). It uses user-agent sniffing to intentionally not bind mouse events for things that look like Android, which is wrong because android can support a plugged in mouse. Also, the way it decides to use pointer events (which eliminates the need for user-agent sniffing) does not work, navigator.pointerEnabled is no longer supported.

https://github.com/paperjs/paper.js/blob/develop/src/view/View.js#L1070-L1090

This causes an issue where (a) you are not able to use an android device with a mouse and (b) if you embed the paint editor in an android webview, then use it on a chromebook for example, the trackpad does not work.

@paulkaplan paulkaplan added the bug label Sep 5, 2019
@adroitwhiz adroitwhiz linked a pull request Jun 14, 2020 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant