Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on Windows & better Windows support #417

Closed
pawelmhm opened this issue Nov 22, 2021 · 2 comments
Closed

Run tests on Windows & better Windows support #417

pawelmhm opened this issue Nov 22, 2021 · 2 comments
Milestone

Comments

@pawelmhm
Copy link
Contributor

pawelmhm commented Nov 22, 2021

Before switching to github actions, we were not running tests on Windows as far as I know.

After switching to github actions most tests were passing on Windows, but coverage is not great, codecov shows around 70%. It is possible tests pass, but some things are not working on windows.

When running windows tests in GitHub actions here #411 I encountered some timeouts, need to figure out if they are related to codebase or to something in GitHub Actions. It would also be good to do some comprehensive testing on windows, users can report what works what doesn't. In my limited manual testing on windows ScrapyD seems to work, but I'm not a heavy windows user and didn't test all functionality. For now I switched off windows https://github.com/scrapy/scrapyd/pull/416/files

Similar things relate to pypy Python, also timeouts sometimes, except here when I run scrapyd locally with pypy I see some problems related to pyc files, need to look closer into this.

@jpmckinney jpmckinney changed the title run tests on windows & better windows support Run tests on Windows & better Windows support Jul 17, 2023
@jpmckinney jpmckinney added this to the 1.x milestone Jul 16, 2024
@jpmckinney
Copy link
Contributor

Opened #513 to see what fails.

@jpmckinney
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants