Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disallow not working when no path is provided #19

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Fix disallow not working when no path is provided #19

merged 1 commit into from
Oct 7, 2021

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Oct 5, 2021

This close #17

I try a simple approach, when we don't have any path we return the default /

@Gallaecio
Copy link
Member

Nice work, thanks!

Copy link
Collaborator

@whalebot-helmsman whalebot-helmsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a fix @Laerte

@whalebot-helmsman whalebot-helmsman merged commit 2a10355 into scrapy:master Oct 7, 2021
@Laerte Laerte deleted the fix/disallow-when-target-path-is-missing branch October 7, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallowing / does not work when the target URL path is missing
3 participants