-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #9
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=======================================
Coverage 98.00% 98.00%
=======================================
Files 4 4
Lines 251 251
=======================================
Hits 246 246
Misses 5 5 Continue to review full report at Codecov.
|
Co-authored-by: Adrián Chaves <[email protected]>
README.rst
Outdated
``itemloaders`` is a library that helps you collect data into models. | ||
|
||
It's specially useful when you need to standardize the data from many sources. | ||
For example, it allows you to have all your casting and parsing rules in a | ||
single place. | ||
|
||
Also, it comes in handy to extract data from web pages, as it supports | ||
data extraction using CSS and XPath Selectors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is a bit confusing to me. Are we suggesting that itemloaders is a general thing, not related to web scraping, which may also come handy for web scraping? Is it really going to be used this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is not restricted to web scraping.
If I want to load a dict
from a XML source, it could be used, right?
Similarly to read from a JSON source or something else..
So, we can have the description related to web scraping or leave it open as a library to standardize the process of extracting/loading data from a source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about explicitly mentioning HTML and XML as the sources of data in the first paragraph, and in the third paragraph replace “comes in handy” with “is specially useful” and move the CSS and XPath part to the first paragraph?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated @Gallaecio
@kmike @Gallaecio , any updates here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current text is fine by me.
I do see @kmike’s point about the introduction, though. Maybe the 2nd and 3rd paragraphs should be inverted, web scraping being what itemloaders is specially useful for, and data standarization being something for which itemloaders can also come in handy.
hey @kmike |
Co-authored-by: Mikhail Korobov <[email protected]>
Co-authored-by: Mikhail Korobov <[email protected]>
Co-authored-by: Mikhail Korobov <[email protected]>
Thanks @ejulio! |
No description provided.