New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_get_func_args() will fail in Python 3.12.3 #76

Closed

wRAR opened this issue Apr 5, 2024 · 1 comment · Fixed by #77

Member

wRAR commented Apr 5, 2024

Looks like python/cpython#86951 has been fixed and so we will need to update the test expectations depending on the version.

Member Author

wRAR commented Apr 14, 2024

According to e.g. https://github.com/scrapy/scrapy/actions/runs/8676036495/job/23790339325?pr=6309 it looks like this fix also happened in e.g. 3.11.9, so maybe we should either just remove the itemgetter test case or expect one of two results, without checking the Python version?

wRAR mentioned this issue

test_get_func_args() expectation changes in new Python point releases scrapy/scrapy#6312

Closed

This was referenced Apr 17, 2024

fix test expectations scrapy/scrapy#6316

Merged

fix test expectations #77

Merged

Gallaecio closed this as completed in #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment