Complete test coverage

Author: Gallaecio

tests/test_nested_loader.py

@@ -98,3 +98,26 @@ def test_nested_load_item(self):
         self.assertEqual(item['name'], ['marta'])
         self.assertEqual(item['url'], ['http://www.scrapy.org'])
         self.assertEqual(item['image'], ['/images/logo.png'])
+
+    def test_nested_from_item(self):
+        """Check that everything works as usual when the nested selector has a
+        parent item"""
+        item = {'foo': 'bar'}
+        loader = ItemLoader(selector=self.selector, item=item)
+        nl1 = loader.nested_xpath('//footer')
+        nl2 = nl1.nested_xpath('img')
+
+        loader.add_xpath('name', '//header/div/text()')
+        nl1.add_xpath('url', 'a/@href')
+        nl2.add_xpath('image', '@src')
+
+        item = loader.load_item()
+
+        assert item is loader.item
+        assert item is nl1.item
+        assert item is nl2.item
+
+        self.assertEqual(item['foo'], ['bar'])
+        self.assertEqual(item['name'], ['marta'])
+        self.assertEqual(item['url'], ['http://www.scrapy.org'])
+        self.assertEqual(item['image'], ['/images/logo.png'])

tests/test_output_processor.py

@@ -4,8 +4,13 @@
 from itemloaders.processors import Identity, Compose, TakeFirst
 
 
-class TestOutputProcessorDict(unittest.TestCase):
-    def test_output_processor(self):
+def take_first(value):
+    return value[0]
+
+
+class TestOutputProcessor(unittest.TestCase):
+
+    def test_item_class(self):
 
         class TempDict(dict):
             def __init__(self, *args, **kwargs):
@@ -22,9 +27,8 @@ class TempLoader(ItemLoader):
         self.assertIsInstance(item, TempDict)
         self.assertEqual(dict(item), {'temp': 0.3})
 
+    def test_item_object(self):
 
-class TestOutputProcessorItem(unittest.TestCase):
-    def test_output_processor(self):
         class TempLoader(ItemLoader):
             default_input_processor = Identity()
             default_output_processor = Compose(TakeFirst())
@@ -35,3 +39,14 @@ class TempLoader(ItemLoader):
         item = loader.load_item()
         self.assertIsInstance(item, dict)
         self.assertEqual(dict(item), {'temp': 0.3})
+
+    def test_unbound_processor(self):
+        """Ensure that a processor not taking a `self` parameter does not break
+        anything"""
+
+        class TempLoader(ItemLoader):
+            default_output_processor = take_first
+
+        loader = TempLoader()
+        loader.add_value('foo', 'bar')
+        self.assertEqual(loader.load_item(), {'foo': 'bar'})

tox.ini

@@ -8,7 +8,7 @@ deps =
 
 commands =
     py.test \
-        --cov-report=term --cov-report=html --cov-report= --cov=itemloaders \
+        --cov-report=term --cov-report=html --cov-report=term-missing --cov=itemloaders \
         --doctest-modules \
         {posargs:itemloaders tests}