Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide a test environment with missing dependencies #10

Open
kmike opened this issue May 20, 2020 · 2 comments · May be fixed by #22 or #33
Open

provide a test environment with missing dependencies #10

kmike opened this issue May 20, 2020 · 2 comments · May be fixed by #22 or #33
Labels
CI Continuous Integration enhancement New feature or request

Comments

@kmike
Copy link
Member

kmike commented May 20, 2020

This should allow to drop some of the mock usages, and test it for real that the package works. I think a single environment without all the dependencies could work; it would only support dict items.
@elacuesta elacuesta added CI Continuous Integration enhancement New feature or request labels May 21, 2020
@elacuesta
Copy link
Member

Sounds fine, although I don't think it should be a blocker for scrapy/scrapy#3881.

One thing to consider is the coverage report. Currently those mocks allow to reach every line in a single environment. With this approach I'll need to do a few adjustments to combine reports from different tox envs. I'm pasting this here so I don't forget: https://help.github.com/en/actions/configuring-and-managing-workflows/persisting-workflow-data-using-artifacts

@kmike
Copy link
Member Author

kmike commented May 21, 2020

@elacuesta I think if you use codecov they combine reports automatically, on their side.

@elacuesta elacuesta linked a pull request May 21, 2020 that will close this issue
Open
@Gallaecio Gallaecio linked a pull request Aug 13, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@kmike @elacuesta