Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax click dependency to make it possible to satisfy other project dependencies #404

Closed
ned2 opened this issue Jun 27, 2021 · 2 comments · Fixed by #416
Closed

relax click dependency to make it possible to satisfy other project dependencies #404

ned2 opened this issue Jun 27, 2021 · 2 comments · Fixed by #416
Labels
dependencies Pull requests that update a dependency file

Comments

@ned2
Copy link

ned2 commented Jun 27, 2021

Currently click is pinned at version 7.0, which makes satisfying all dependency constraints for a project that also has shub installed difficult, especially given that click 7.0 was released in September 2018, with the latest version being 8.0.1.

Is there a reason for pinning click? If not, could this be relaxed to make it easier to use with other packages in the same virtual environment?

If, on the other the shub package is not intended to be an installed library and rather just an executable, perhaps the documentation need to make this clear, and suggest installing the package with a tool like pipx, which creates a standalone virtual environment, rather than with pip into the current environment.

@apalala apalala added the dependencies Pull requests that update a dependency file label Sep 8, 2021
@muscovitebob
Copy link

This is painful especially with the new pip resolver algorithm which will attempt to find a satisfactory dependency anyway.

@apalala
Copy link
Contributor

apalala commented Sep 15, 2021

I'm working on fixing this. It consists mostly on dropping support for Python 2.7, but I found the same has to be done on python-scrapinghub for the fix to be complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants