Fix build issue on macOS (aarch64, gcc) and use debugtrap wherever possible #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix typos in macro names.
This also fixes a build issue on macOS (Apple silicon) when a real GCC compiler is used: > warning: implicit declaration of function '__builtin_debugtrap'; Signed-off-by: Jonathan Wakely <[email protected]> Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
fix-apple-silicon-gcc-and-use-debugtrap-where-possible
branch
from
826e258
to
83bf7e9
Compare
|
I'll see if I can test it on powerpc64. |
MrAnno
added a commit
to MrAnno/Criterion
that referenced
this pull request
Feb 6, 2022
Currently, this bump contains unmerged changes: scottt/debugbreak#25
|
I've completed my tests on the platforms that were available to me. @scottt What do you think? Is this something you would consider integrating into the master branch? |
|
on POWER8 running CentOS 7.9: |
|
@jwakely Thank you. |
MrAnno
added a commit
to MrAnno/Criterion
that referenced
this pull request
Feb 12, 2022
The following contribution fixes a gcc compilation issue on macOS: scottt/debugbreak#25 This commit replaces the upstream repo with a fork until the above PR gets integrated into the upstream master.
|
@scottt Could you have a look at this? |
|
We had to start using a fork of debugbreak due to this build issue on macOS. |
|
@scottt Do you have any comments on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
debugbreakprefer__builtin_debugtrap()wherever it's available (clang).The code snippet I've used is @jwakely's work, I've added a signoff to my commit message to mark the original author.
The patch fixes a build issue too on macOS (Apple silicon) when a real GCC compiler is used:
Depends on #22
Fixes #24
I'm testing this change on the following architectures (with clang + gcc):
Unfortunately, I won't be able to test the change on riscv and powerpc.