This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
Server: catch up on missed ticks #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On heavy load, or when upgrading the server, the plugin might not tick every seconds. To better quantify this, log when some ticks are missed.
Catches up ticks up to 10 minutes (as longer may overload the server when starting up after being stopped a very long time). If it takes longer to catch up for ticks that a tick, the missed ticks will be caught up on the next turn.
|
awaiting response from mm team regarding #195 (comment) before movement on this pull request |
scottleedavis
approved these changes
Mar 14, 2023
|
Thanks! In my real-life tests, this didn’t entirely prevent recurring reminders to be dropped from time to time - but it helped a lot to make this less frequent. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #143
The issue
As outlined in the issue, every second the plugin ticks to trigger reminder occurrences. However various reasons might cause the tick to miss a second or more: server jittery (very frequent), or a temporary downtime or upgrade. In those case, some occurrences will never be triggered.
The fix
This PR saves the last tick time in a
LastTickAtkey, and uses it to catch up on missed ticks.If the server has been down for more than 10mn, older ticks are dropped (in order not to hammer the database by catching up on a 20 000 ticks at once).
The implementation
This PR has two commit:
It should be quite readable, and has tests.
@scottleedavis @hanzei does that look good to you?