Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Cannot snooze a reminder from a recurring schedule #174

Open
Roy-Orbison opened this issue Jan 31, 2020 · 3 comments
Open

Cannot snooze a reminder from a recurring schedule #174

Roy-Orbison opened this issue Jan 31, 2020 · 3 comments
Labels
Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Type/Bug Something isn't working
Milestone

Comments

@Roy-Orbison
Copy link

Summary

The snooze drop-down does nothing if the reminder is a recurring one.

Steps to reproduce

  1. Issue a command such as /remind me FOOBAR every day at <2 minutes from your current time>
  2. Wait for reminder message
  3. Try to select snooze option from message

Expected behaviour

That instance of the reminder should be snoozed

Observed behaviour (that appears unintentional)

Nothing happens, message remains.

Server configuration

Operating system: Debian

Mattermost version: Community 5.18.1

Remind version: 0.4.4

Updated from an older Remind bot version or fresh install: Updated

Mattermost server logs
{"level":"error","ts":1580428486.372024,"caller":"mlog/log.go:174","msg":"Plugin failed to ServeHTTP, RPC call failed","plugin_id":"com.github.scottleedavis.mattermost-plugin-remind","error":"unexpected EOF"}

Additional context

See comments here.

@scottleedavis scottleedavis added the Type/Bug Something isn't working label May 2, 2020
@scottleedavis
Copy link
Owner

@hanzei Plugin failed to ServeHTTP, RPC call failed...
perhaps handleSnooze
https://github.com/scottleedavis/mattermost-plugin-remind/blob/master/server/http.go#L342

@Roy-Orbison
Copy link
Author

Also, if multiple snooze attempts are made to a recurring reminder, the plugin will crash and have to be disabled & re-enabled from the System Console, otherwise it won't respond to any slash commands.

@scottleedavis scottleedavis added the Good First Issue Suitable for first-time contributors label May 10, 2020
@scottleedavis scottleedavis added this to the 0.5.0 milestone May 10, 2020
@scottleedavis scottleedavis added the Help Wanted Community help wanted label May 10, 2020
@scottleedavis scottleedavis modified the milestones: 0.5.0, backlog May 10, 2020
@Roy-Orbison
Copy link
Author

I thought of a possible solution for this issue. Because snoozing only applies to the current instance of the recurring reminder, but (I'm guessing) the data model doesn't have a record of instances, snoozing could:

  1. clone the original reminder
  2. drop the clone's recurring schedule and set its date & time to the original's + the snooze duration
  3. dismiss the original as if it had been marked as completed

It's a little hackish, but likely easier to implement than something that requires changing the model. A consequence would be that deleting a clone would not delete the original schedule, which I see as a positive. I'd be happy with that over plugin crashes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Type/Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants