Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links in markdown codeblocks are being checked #13

Open
sappelhoff opened this issue Mar 25, 2021 · 1 comment
Open

links in markdown codeblocks are being checked #13

sappelhoff opened this issue Mar 25, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@sappelhoff
Copy link

sappelhoff commented Mar 25, 2021

Hi, thanks a lot for your package!

Using the up-to-date pip install of the package, the following URL is flagged when running from the command line:

`[[URL](URL)]`

this is in line 352 of this file: https://github.com/sappelhoff/bids-specification/blob/master/CONTRIBUTING.md

I would have expected links in markdown inline code blocks to not be checked. Is that a wrong expectation? Or is it something to improve in the code?

@scivision scivision added the enhancement New feature or request label Mar 25, 2021
@scivision
Copy link
Owner

It's something to improve. I hadn't made the regular expression used that complicated so this is something that would happen yes. At some point, there would be a speed penalty as the regex gets more an more complicated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants