Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interp code for modifiers (generic labels infrastructure?) #246

Closed
lukasheinrich opened this issue Sep 8, 2018 · 1 comment
Closed
Labels
wontfix This will not be worked on

Comments

@lukasheinrich
Copy link
Contributor

lukasheinrich commented Sep 8, 2018

Description

some modifiers implement their modification as an interpolation between user-provided data (e.g. histosys and normsys). As these computations are typically expensive we want to vectorize these as much as possible #231 (even across multiple modifiers -- the meta-modifier idea). To do this we need a way to group these computations by e.g. interpolation type.

comment:
This is not a generic property of modifiers and we are now adding more and more decorators to them (is_constrained, pdf_type, interp_code..) so maybe at some point we might consider a generic labels key-value infrastructure instead of adding properties one by one

@lukasheinrich lukasheinrich changed the title add interp code for modifiers (generic labels infrastructure) add interp code for modifiers (generic labels infrastructure?) Sep 8, 2018
@kratsg kratsg added the wontfix This will not be worked on label Oct 21, 2018
@kratsg
Copy link
Contributor

kratsg commented Oct 21, 2018

Given the way #285 is going -- this is going to be slowly irrelevant as we've moved the interpolation into the paramset labeling and other properties like is_constrained will be going away -- and overall, the modifier decorator is most likely going to disappear.

@kratsg kratsg closed this as completed Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants