Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to install it on windows #15

Open
bykka opened this issue Jul 31, 2020 · 5 comments
Open

It is not possible to install it on windows #15

bykka opened this issue Jul 31, 2020 · 5 comments

Comments

@bykka
Copy link

bykka commented Jul 31, 2020

Windows does not have a python, so npm install finished with the exception

image

@schroffl
Copy link
Owner

Python is required by node-gyp, which is a package we depend on. I'm not happy about this constraint either, but – to be frank – I don't have the time to work around that right now.

If you are familiar with this topic, please feel free to submit a pull request and I will take a look at it :)

@bykka
Copy link
Author

bykka commented Aug 2, 2020

Why not include pre-compiled versions of lzo library to the package?

@schroffl
Copy link
Owner

schroffl commented Aug 3, 2020

I guess this is a possibility, but then you would also need to either pre-compile it for all platforms or have a fallback that will try to compile it locally when there's no pre-compiled version available. However, in the latter case, one needs to have python installed again.

You also need to include all those builds in the package tar-ball, which would considerably increase the size. Of course, you can host those builds on a server and just download them as needed, but such infrastructure requires some maintenance.

@schroffl
Copy link
Owner

schroffl commented Aug 5, 2020

I just wanted to add that you should absolutely share your ideas and thoughts! My last post sounded kind of cynical and like I just wanted to shut this issue down, but that's not the case :)

@bykka
Copy link
Author

bykka commented Aug 6, 2020

I'm not very familiar with npm. I just thought that "npm install" simply downloads dependencies without any additional actions.
At the current moment, I used "docker" to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants