-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From old issue #290 #670
Comments
if somebody can implement a proper test case, im open for merging it |
A test which ensure that a EntityNotFoundException is throw when the entity IDENTIFIER is inconsistent? There is no test covering such a case already? If so, you could just extend it by adding the fallback code part as shown in #290, right? if(null === $object) { // Added code part
return $this->fallbackConstructor->construct($visitor, $metadata, $data, $type, $context);
} |
as said in #290 you can create a new pr with a testcase for it |
Did you read my question at least? The question is: Does a testcase already exists for ensuring that EntityNotFoundException is raised ? I would be happy to provide a PR, including a testcase but I would be also happy to known the purpose of that testcase. You known your code better than us. BTW: We could also answer you: There is a bug regarding this. Please, fix it. You're the maintainer after all ;) If you don't fix it, we cannot trust to your work because you don't care much about the issues that were reported since many months and which are reproducible by many people ;) Thank you for your understanding. |
Funny answer (ironic).... To be more serious, If all open-source community acted like you, nobody would use an open-source software... Your answer here is really an asshole' answer. If you have not more interest for that library, just go ahead but don't provide such answer which only discredits the project. I don't understand how such a guy can be a collaborator on this project. |
We have same problem described in #290 :
ReflectionProperty::setValue() expects parameter 1 to be object, null given in .../vendor/jms/metadata/src/Metadata/PropertyMetadata.php:60
Solution proposed by @nuxwin still working
The text was updated successfully, but these errors were encountered: