Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From old issue #290 #670

Closed
mmeloni opened this issue Nov 3, 2016 · 6 comments
Closed

From old issue #290 #670

mmeloni opened this issue Nov 3, 2016 · 6 comments

Comments

@mmeloni
Copy link

mmeloni commented Nov 3, 2016

We have same problem described in #290 :

ReflectionProperty::setValue() expects parameter 1 to be object, null given in .../vendor/jms/metadata/src/Metadata/PropertyMetadata.php:60

Solution proposed by @nuxwin still working

@goetas
Copy link
Collaborator

goetas commented Nov 3, 2016

if somebody can implement a proper test case, im open for merging it

@nuxwin
Copy link

nuxwin commented Nov 4, 2016

@goetas

A test which ensure that a EntityNotFoundException is throw when the entity IDENTIFIER is inconsistent? There is no test covering such a case already? If so, you could just extend it by adding the fallback code part as shown in #290, right?

if(null === $object) { // Added code part
    return $this->fallbackConstructor->construct($visitor, $metadata, $data, $type, $context);
}

@goetas
Copy link
Collaborator

goetas commented Nov 4, 2016

as said in #290 you can create a new pr with a testcase for it

@nuxwin
Copy link

nuxwin commented Nov 4, 2016

@goetas

Did you read my question at least? The question is: Does a testcase already exists for ensuring that EntityNotFoundException is raised ? I would be happy to provide a PR, including a testcase but I would be also happy to known the purpose of that testcase. You known your code better than us.

BTW: We could also answer you: There is a bug regarding this. Please, fix it. You're the maintainer after all ;) If you don't fix it, we cannot trust to your work because you don't care much about the issues that were reported since many months and which are reproducible by many people ;)

Thank you for your understanding.

@goetas
Copy link
Collaborator

goetas commented Nov 4, 2016

@nuxwin please read the License provided with this software and its terms and conditions (especially sections 7,8,9)

@nuxwin
Copy link

nuxwin commented Nov 4, 2016

@goetas

Funny answer (ironic)....

To be more serious, If all open-source community acted like you, nobody would use an open-source software... Your answer here is really an asshole' answer. If you have not more interest for that library, just go ahead but don't provide such answer which only discredits the project.

@schmittjoh

I don't understand how such a guy can be a collaborator on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants