Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on mcrypt #196

Closed
ruudk opened this issue Dec 5, 2016 · 3 comments
Closed

Remove dependency on mcrypt #196

ruudk opened this issue Dec 5, 2016 · 3 comments
Milestone

Comments

@ruudk
Copy link
Contributor

ruudk commented Dec 5, 2016

It's been deprecated in PHP 7.1

http://php.net/manual/en/migration71.deprecated.php

@ruudk
Copy link
Contributor Author

ruudk commented Dec 5, 2016

Function mcrypt_list_algorithms() is deprecated in /home/app/releases/20161205121224/vendor/jms/payment-core-bundle/JMS/Payment/CoreBundle/Cryptography/MCryptEncryptionService.php on line 49
Deprecated: Function mcrypt_list_algorithms() is deprecated in /home/app/releases/20161205121224/vendor/jms/payment-core-bundle/JMS/Payment/CoreBundle/Cryptography/MCryptEncryptionService.php on line 49
PHP Deprecated:  Function mcrypt_list_modes() is deprecated in /home/app/releases/20161205121224/vendor/jms/payment-core-bundle/JMS/Payment/CoreBundle/Cryptography/MCryptEncryptionService.php on line 53
Deprecated: Function mcrypt_list_modes() is deprecated in /home/app/releases/20161205121224/vendor/jms/payment-core-bundle/JMS/Payment/CoreBundle/Cryptography/MCryptEncryptionService.php on line 53
PHP Deprecated:  Function mcrypt_get_key_size() is deprecated in /home/app/releases/20161205121224/vendor/jms/payment-core-bundle/JMS/Payment/CoreBundle/Cryptography/MCryptEncryptionService.php on line 65
Deprecated: Function mcrypt_get_key_size() is deprecated in /home/app/releases/20161205121224/vendor/jms/payment-core-bundle/JMS/Payment/CoreBundle/Cryptography/MCryptEncryptionService.php on line 65

@psrpinto
Copy link
Collaborator

psrpinto commented Dec 6, 2016

Thanks for reporting this. I had no idea mcrypt was in such bad shape.

There seem to be two options:

  1. Using OpenSSL, which requires the OpenSSL extension
  2. Use defuse/php-encryption which has no dependencies but requires PHP 5.4

I'm more in favor of defuse/php-encryption since it has no dependencies, even though it will require us to drop PHP 5.3 support (it's about time anyway).

@psrpinto psrpinto added this to the 2.0.0 milestone Jan 7, 2017
@psrpinto psrpinto modified the milestones: 2.0.0, 1.3.0 Jan 8, 2017
@psrpinto
Copy link
Collaborator

Usage of mcrypt within this bundle has now been deprecated in favour of defuse/php-encryption, which is now the default encryption provider for new installations. Existing installations keep using mcrypt in order to maintain BC. See the Change log for 1.3.0 for more information.

Thanks for reporting this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants