-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating Panel close automatically after change in PR #551 #561
Comments
Thank you for this report. I understood the side effect of the code. |
It is a new panel that I create that I try to open in full or half. I see the panel going to the right position but then it close itself automatically |
Thanks. I created iss-561 branch. Could you try it in your app? |
Thanks for the quick reply. It is working with your new branch. |
Thanks for your confirmation. I'm going to merge the branch into the main line in PR #563. |
This resolves issue #561. Instead of continuing to work a modal presentation transition even if a panel state is not .hidden, this library calls fatalError as a programmer error on the occasion.
@bvaillant-clgx I merged iss-561 branch, and then I will release it in the next release, v2.5.4. Thank you so much. |
I'm using the Floating Panel to show a page with lots of informations but since the last update (2.5.3) every times I try to open it the floating panel close itself.
I found out that if I put the line added in the PR #551 in comment, my problem is not there anymore.
My panel are shown modally
I also have special code that dismiss the FloatingPanelController when the state is hidden that I absolutely need.
func floatingPanelDidMove(_ fpc: FloatingPanelController) { if fpc.state == .hidden { fpc.dismiss(animated: true, completion: { ... } }) } }
The text was updated successfully, but these errors were encountered: