Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak From set(contentViewController:) Function #655

Open
Obsidian-Watermelon opened this issue Dec 23, 2024 · 0 comments
Open

Memory Leak From set(contentViewController:) Function #655

Obsidian-Watermelon opened this issue Dec 23, 2024 · 0 comments

Comments

@Obsidian-Watermelon
Copy link

Obsidian-Watermelon commented Dec 23, 2024

スクリーンショット 2024-12-13 17 41 51

Description

As shown in the screenshot, there seems to be a retain cycle occurring when SurfaceView set(contentView:mode:) function is running in the set(contentViewController:) function in FloatingPanelController. I believe it is occurring since the contentView being passed as a parameter is being added as a subView rather that SurfaceView's self.contentView being added.

Steps to reproduce

Code example that reproduces the issue
let contentVC = ContentViewController()
self.fpc.set(contentViewController: contentVC)

How do you display panel(s)?

  • Add as child view controllers

How many panels do you displays?

  • 1

Environment

Library version
2.8.6

Installation method

  • CocoaPods

iOS version(s)
18.1.1

Xcode version
16.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant