Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to use .half height but allow people to pull the panel farther? #401

Open
warpling opened this issue Nov 6, 2020 · 6 comments

Comments

@warpling
Copy link
Contributor

warpling commented Nov 6, 2020

Is it possible to configure a panel with only a .half height anchor to be able to be pulled up (towards the top of screen) without providing a full-size anchor? I have tried overriding floatingPanelDidMove to allow the surface location to be anything, have shouldProjectMomentum and allowsRubberBanding enabled, yet can't seem to replicate this behavior. Am I missing something or is this not currently possible. Thanks!

@scenee
Copy link
Owner

scenee commented Nov 7, 2020

it might not be possible on occasion. Here is my repro steps.

  1. Comment out here: https://github.com/SCENEE/FloatingPanel/blob/master/Examples/Samples/Sources/ViewController.swift#L477
  2. Run Samples.app

and then,

"Scroll tracking(TextView)" and "Show Detail Panel" are OK.
"Scroll tracking(TableView)" looks NG.

After investigating the above NG case, I found a code to be fixed about the scroll tracking. And then I made a patch in iss-401 branch. Could you please try it?

[Edit]
I've force-pushed iss-401(15e9808) because I found some issues.

@warpling
Copy link
Contributor Author

I might wait to test this since it's so closely related to the relative anchor issue/PR.

@alouanemed
Copy link

Any update to this?

@scenee
Copy link
Owner

scenee commented Dec 12, 2020

Hello @warpling, could you please check #407?

@warpling
Copy link
Contributor Author

Hey @scenee, sorry I never was able to test this. I hope someone else can confirm it is working! Perhaps unrelated, but I did recently notice that .full panels can now be dragged up to any height if they are initially pulled down; they cannot be dragged up and higher from .full if they have not been dragged down first.

@scenee
Copy link
Owner

scenee commented Jan 31, 2021

Thank you for your testing and sharing a problem, @warpling. I will investigate the following issue later.

they cannot be dragged up and higher from .full if they have not been dragged down first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants