Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background doesn't dim as expected #376

Closed
warpling opened this issue Jul 30, 2020 · 4 comments · Fixed by #416
Closed

Background doesn't dim as expected #376

warpling opened this issue Jul 30, 2020 · 4 comments · Fixed by #416

Comments

@warpling
Copy link
Contributor

Expected behavior:
The backdropView behind panels will dim or turn a translucent black.

Actual behavior:
The backdropView appears clear.

How to reproduce:
Run the stocks example. I tested on iOS 12 and 14.

Using: The latest copy of the repository as of July 30th 2020.

@warpling warpling changed the title Background dimming is not working Background doesn't dim as expected Jul 30, 2020
@warpling
Copy link
Contributor Author

It turns out the dimming DOES work it just doesn't show up until the panel is nearly fully expanded. I think this also means that tap to dismiss does not work when a panel is at half height though as I am unable to get touch events when the panel is at half height but can at full height.

@jnwagstaff
Copy link

I experienced the same thing with .half, it seems like the backdrop view isn't there. If you implement the backdropAlpha function for the FloatingPanelLayout and return a value for .half it is present and tap to dismiss works again.

@WrathChaos
Copy link

@scenee, I think @jnwagstaff answer should be on README.

@scenee
Copy link
Owner

scenee commented Dec 19, 2020

@WrathChaos I agree with you 👍 I will add an explanation about the backdrop alpha API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants