Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tableview's didSelectRowAt method not getting called in v1.6.0 #222

Closed
1 of 3 tasks
Isuru-Nanayakkara opened this issue Jun 14, 2019 · 8 comments
Closed
1 of 3 tasks
Labels
bug Something isn't working

Comments

@Isuru-Nanayakkara
Copy link

Short description

I have a UITableViewController embedded in the floating panel. When I single tap on any cell, the didSelectRowAt method gets fired. But since the latest version, this behavior has become erratic. I have to double tap on cells for the didSelectRowAt method to fire.

Expected behavior

didSelectRowAt method to fire on single tap. This worked fine in v1.4.0.

Steps to reproduce

  • Have the floating panel initial position has half.
  • Swipe up to full position and tap on a cell. didSelectRowAt does not fire.
  • Tap on that cell again. Now the didSelectRowAt fires.

Another behavior I noticed.

  • Have the floating panel initial position has half.
  • Swipe up on the floating panel but before it reaches full position, let go so it slides back down.
  • Now swipe it up fully again.
  • Tap on a cell and the didSelectRowAt fires.

Environment

Library version
1.6.0

Installation method

  • CocoaPods
  • Carthage
  • Git submodules

iOS version(s)
12.2

Xcode version
10.2.1

@scenee
Copy link
Owner

scenee commented Jun 15, 2019

Could you please check the repro when you comment out the line?
(I'd like you to ensure that you rebuild the library after cleaning derived data)

@scenee scenee added the bug Something isn't working label Jun 15, 2019
@Isuru-Nanayakkara
Copy link
Author

Is it okay to edit the source files even if I add the library to my project via CocoaPods?

@scenee
Copy link
Owner

scenee commented Jun 15, 2019

Yes, it is!

@Isuru-Nanayakkara
Copy link
Author

Tried it. Cleaned the DerviedData folder manually too. But the issue persists.

@scenee
Copy link
Owner

scenee commented Jun 15, 2019

Thanks, it looks same as #164.
As the comment mentioned, it seems to be an issue of UITableView. I tried to fix it in a couple of days but it's hard to fix it completely..

@Isuru-Nanayakkara
Copy link
Author

Oh, that sucks. I guess I'll revert back to v1.4.0 for now. Everything works fine in that version.

@scenee
Copy link
Owner

scenee commented Jun 15, 2019

Oh, I missed it. This might be not same issue as #164 reported on v1.4.0. I need to investigate this more.


iOS 13 seems to fix the didSelectRowAt issue reported on #164.

@HappyIosDeveloper
Copy link

I still have this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants