Remove target-action for an untracked scroll view

scenee · scenee · commit c4f7fa533298 · 2019-09-27T23:47:36.000+09:00
diff --git a/Framework/Sources/FloatingPanel.swift b/Framework/Sources/FloatingPanel.swift
@@ -19,8 +19,8 @@ class FloatingPanel: NSObject, UIGestureRecognizerDelegate {
 
     weak var scrollView: UIScrollView? {
         didSet {
-            guard let scrollView = scrollView else { return }
-            scrollView.panGestureRecognizer.addTarget(self, action: #selector(handle(panGesture:)))
+            oldValue?.panGestureRecognizer.removeTarget(self, action: nil)
+            scrollView?.panGestureRecognizer.addTarget(self, action: #selector(handle(panGesture:)))
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,8 @@ class FloatingPanel: NSObject, UIGestureRecognizerDelegate {`
`19`	`19`
`20`	`20`	`weak var scrollView: UIScrollView? {`
`21`	`21`	`didSet {`
`22`		`- guard let scrollView = scrollView else { return }`
`23`		`- scrollView.panGestureRecognizer.addTarget(self, action: #selector(handle(panGesture:)))`
	`22`	`+ oldValue?.panGestureRecognizer.removeTarget(self, action: nil)`
	`23`	`+ scrollView?.panGestureRecognizer.addTarget(self, action: #selector(handle(panGesture:)))`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`