Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some documentation issues #4

Open
jeremybdk opened this issue Jul 9, 2023 · 1 comment
Open

Some documentation issues #4

jeremybdk opened this issue Jul 9, 2023 · 1 comment

Comments

@jeremybdk
Copy link

Hello,
First thank you for this action, it's one of the last piece that we have not yet replaced from our deploy process to Heroku and I really appreciate having a simple way to deploy from GitHub Actions to Scalingo.

I've been trying to setup this actions to auto deploy our review app based on a comment on our PR, but I'm having some difficulties getting everything to work.

First, there is some issue in the documentation:

  • the @v1 action does not exist yet, @v0.1.1 should be used
  • api_token: '${{ secrets.scalingo_api_token }} should be api_token: ${{ secrets.scalingo_api_token }}
  • - Configure Scalingo CLI should be -name: Configure Scalingo CLI

The next issue I'm facing with git, it seems that the repository get added as expected, but I don't have any rights to read or write to it. Do I also need to add an SSH key to my GitHub action to be able to push to my repo or am I missing something?

Thank you

@jeremybdk jeremybdk changed the title Some issues Some documentation issues Jul 9, 2023
@josephpage josephpage reopened this Aug 21, 2023
@josephpage
Copy link
Collaborator

Hello, thank you very much for your invaluable feedback, which I see on my return from vacation. I've just corrected the little issues in the documentation. I'm trying to use the extra-files option of release-please to update the version number of the Action automatically, I hope it will work to match the most recent version.

To use Git, as you said, you'll need to set up an SSH key, because unfortunately Scalingo doesn't support HTTPS connections. I haven't yet used the action in this way, in fact I've just implemented the basic option since it was present on the CLI. You should probably use an action like this to install the SSH key: Install SSH key (Github Marketplace) Feel free to let me know how you achieve so I can include it in the documentation or even inside the Composite Action.

Thanks a lot and have a nice week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants