Skip to content

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented May 20, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@yfodil yfodil self-assigned this May 20, 2025
@yfodil yfodil requested review from a team and remyleone as code owners May 20, 2025 07:34
@github-actions github-actions bot added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label May 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

Attention: Patch coverage is 52.65957% with 89 lines in your changes missing coverage. Please review.

Project coverage is 55.07%. Comparing base (5bf53e0) to head (66b1638).
Report is 633 commits behind head on master.

Files with missing lines Patch % Lines
...ternal/namespaces/vpc/v2/custom_private_network.go 64.28% 45 Missing and 10 partials ⚠️
...nal/namespaces/mongodb/v1alpha1/custom_instance.go 0.00% 30 Missing ⚠️
internal/namespaces/mongodb/v1alpha1/custom.go 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (66b1638). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (66b1638)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4742       +/-   ##
===========================================
- Coverage   75.45%   55.07%   -20.38%     
===========================================
  Files         202      312      +110     
  Lines       44323    79934    +35611     
===========================================
+ Hits        33444    44024    +10580     
- Misses       9653    34492    +24839     
- Partials     1226     1418      +192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remyleone remyleone added this pull request to the merge queue May 21, 2025
Merged via the queue into scaleway:master with commit 5bac52b May 21, 2025
14 checks passed
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants