ci: fix windows t.TempDir issue with concurrent delete (#4505)

Author: remyleone

internal/namespaces/instance/v1/custom_user_data_test.go

@@ -52,16 +52,22 @@ func Test_UserDataList(t *testing.T) {
 	}))
 }
 
-func Test_UserDataFileUpload(t *testing.T) {
+func Test_UserDataFileUploadOn(t *testing.T) {
 	content := "cloud-init file content"
+	file, err := os.CreateTemp(t.TempDir(), "test")
+	if err != nil {
+		t.Fatalf("%s", err)
+	}
+	_, err = file.WriteString(content)
+	if err != nil {
+		t.Fatalf("%s", err)
+	}
 
-	t.Run("on-cloud-init", core.Test(&core.TestConfig{
+	t.Run("cloud-init", core.Test(&core.TestConfig{
 		Commands: instance.GetCommands(),
 		BeforeFunc: core.BeforeFuncCombine(
 			core.ExecStoreBeforeCmd("Server", testServerCommand("stopped=true")),
 			func(ctx *core.BeforeFuncCtx) error {
-				file, _ := os.CreateTemp(t.TempDir(), "test")
-				_, _ = file.WriteString(content)
 				ctx.Meta["filePath"] = file.Name()
 
 				return nil
@@ -71,22 +77,40 @@ func Test_UserDataFileUpload(t *testing.T) {
 		Check: core.TestCheckCombine(
 			core.TestCheckGolden(),
 		),
-		AfterFunc: core.AfterFuncCombine(
-			func(ctx *core.AfterFuncCtx) error {
-				_ = os.RemoveAll(ctx.Meta["filePath"].(string))
+		AfterFunc: func(_ *core.AfterFuncCtx) error {
+			// We need to close this file explicitly because it is not closed by the os.Remove call on windows
+			// https://github.com/golang/go/issues/50510
+			err = file.Close()
+			if err != nil {
+				return err
+			}
 
-				return nil
-			},
-		),
+			err = os.RemoveAll(file.Name())
+			if err != nil {
+				return err
+			}
+
+			return nil
+		},
 	}))
+}
 
-	t.Run("on-random-key", core.Test(&core.TestConfig{
+func Test_UserDataFileUploadOnRandom(t *testing.T) {
+	content := "cloud-init file content"
+	file, err := os.CreateTemp(t.TempDir(), "test")
+	if err != nil {
+		t.Fatalf("%s", err)
+	}
+	_, err = file.WriteString(content)
+	if err != nil {
+		t.Fatalf("%s", err)
+	}
+
+	t.Run("key", core.Test(&core.TestConfig{
 		Commands: instance.GetCommands(),
 		BeforeFunc: core.BeforeFuncCombine(
 			core.ExecStoreBeforeCmd("Server", testServerCommand("stopped=true")),
 			func(ctx *core.BeforeFuncCtx) error {
-				file, _ := os.CreateTemp(t.TempDir(), "test")
-				_, _ = file.WriteString(content)
 				ctx.Meta["filePath"] = file.Name()
 
 				return nil
@@ -96,12 +120,20 @@ func Test_UserDataFileUpload(t *testing.T) {
 		Check: core.TestCheckCombine(
 			core.TestCheckGolden(),
 		),
-		AfterFunc: core.AfterFuncCombine(
-			func(ctx *core.AfterFuncCtx) error {
-				_ = os.RemoveAll(ctx.Meta["filePath"].(string))
+		AfterFunc: func(_ *core.AfterFuncCtx) error {
+			// We need to close this file explicitly because it is not closed by the os.Remove call on windows
+			// https://github.com/golang/go/issues/50510
+			err = file.Close()
+			if err != nil {
+				return err
+			}
 
-				return nil
-			},
-		),
+			err = os.RemoveAll(file.Name())
+			if err != nil {
+				return err
+			}
+
+			return nil
+		},
 	}))
 }