Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax type constraints on assertEquals method signature #434

Closed
olafurpg opened this issue Oct 16, 2021 · 1 comment
Closed

Relax type constraints on assertEquals method signature #434

olafurpg opened this issue Oct 16, 2021 · 1 comment
Milestone

Comments

@olafurpg
Copy link
Member

Currently, the following expression fails to compile assertEquals(Some(1), Option(1)) while assertEquals(Option(1), Some(1)) compiles. The compile error message is also cryptic. This issue is about relaxing the type constraints on the method signature to allow more flexible ordering of parameters and have less cryptic compile errors.

@valencik
Copy link
Collaborator

This was completed in #521

All of the following now compile in v1.0.0 milestones:

assertEquals(Option(1), Some(1))
assertEquals(Some(1), Option(1))
assertEquals(Option(1), Option(1))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants