Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing class parameters doesnt recompile dependent code #6112

Closed
sake92 opened this issue Feb 12, 2024 · 3 comments
Closed

Changing class parameters doesnt recompile dependent code #6112

sake92 opened this issue Feb 12, 2024 · 3 comments
Labels
bug Something that is making a piece of functionality unusable upstream-fix-needed Waiting on a fix upstream
Milestone

Comments

@sake92
Copy link
Contributor

sake92 commented Feb 12, 2024

Describe the bug

I got an interesting error in VSCode+Metals.
Project is using scala 3.3.1 and Mill.
If I add/remove class parameters, the code that is calling it still compiles..

Seems like with 2.13 it works fine, not sure if it is Mill, Metals or Zinc issue.. :/

Repro: https://github.com/sake92/metals-mill-scala3-class-params-repro

Expected behavior

Code doesnt compile after updating parameters

Operating system

Windows

Editor/Extension

VS Code

Version of Metals

1.2.1

Extra context or search terms

No response

@kasiaMarek
Copy link
Contributor

kasiaMarek commented Feb 13, 2024

Thanks for the report. I can reproduce that. It's not a metals issue, we only send requests to the build server to compile a specific build target. I can reproduce this with both bloop and mill, and even if I switch the build tool to be sbt, so I'd say it's probably a Zinc issue and should be raised there.

@kasiaMarek kasiaMarek added upstream-fix-needed Waiting on a fix upstream bug Something that is making a piece of functionality unusable labels Feb 13, 2024
@eed3si9n
Copy link

Not sure if this is the right fix, but changing one line in Scala 3 compiler fixes this - scala/scala3#19911

@kasiaMarek
Copy link
Contributor

Closing this as resolved by: scala/scala3#19911

@tgodzik tgodzik added this to the Metals v1.3.3 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is making a piece of functionality unusable upstream-fix-needed Waiting on a fix upstream
Projects
None yet
Development

No branches or pull requests

4 participants