You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The !matchesSimpleDefinition predicate is related to the rule configuration skipSimpleDefinitions (link). This predicate is only evaluated in the qualifyingNonImplicit block, while most likely it always needs to be evaluated, together with the matchesMemberKindAndVisibility block.
First of all this assumption needs to be confirmed as part of this issue.
The same thoughts can be valid for !onlyImplicits block which is related to a new configuration of ExplicitResultTypes.
Given that the assumption holds true, moving !matchesSimpleDefinition out of qualifyingNonImplicit will make the qualifyingNonImplicit method name reflect what it actually does and will make this method more readable and maintainable.
In ExplicitResultTypes there's a block of code potentially broken and hard to read:
The
!matchesSimpleDefinition
predicate is related to the rule configurationskipSimpleDefinitions
(link). This predicate is only evaluated in thequalifyingNonImplicit
block, while most likely it always needs to be evaluated, together with thematchesMemberKindAndVisibility
block.First of all this assumption needs to be confirmed as part of this issue.
The same thoughts can be valid for
!onlyImplicits
block which is related to a new configuration of ExplicitResultTypes.Given that the assumption holds true, moving
!matchesSimpleDefinition
out ofqualifyingNonImplicit
will make thequalifyingNonImplicit
method name reflect what it actually does and will make this method more readable and maintainable.This change was proposed in PR #1627
Current scalafix version is 0.10.1
The text was updated successfully, but these errors were encountered: