Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy link resolution should only use directoryName not the name #8237

Closed
MichaelBuessemeyer opened this issue Nov 27, 2024 · 0 comments · Fixed by #8257
Closed

Legacy link resolution should only use directoryName not the name #8237

MichaelBuessemeyer opened this issue Nov 27, 2024 · 0 comments · Fixed by #8257

Comments

@MichaelBuessemeyer
Copy link
Contributor

Detailed Description

In Dataset.scala in findOneByNameAndOrganization uses (directoryName = $name OR name = $name) to identify a dataset. We added the support for finding by name for edge case scenarios like a user creating a link to a renamed wk dataset with an outdated tool. However, using only directoryName stays more consistent with the past wk addressing model and does not have the potential to find a different dataset. Therefore we should consider removing the OR name = $name clause from the query.

@fm3 fm3 changed the title Legacy link resolution should only used directoryName not the name Legacy link resolution should only use directoryName not the name Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant