Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipping distance changes with zoom in arbitrary mode #7725

Open
3 tasks
philippotto opened this issue Mar 27, 2024 · 4 comments
Open
3 tasks

Clipping distance changes with zoom in arbitrary mode #7725

philippotto opened this issue Mar 27, 2024 · 4 comments

Comments

@philippotto
Copy link
Member

Context

Skeleton nodes are only rendered when they are within the configured clipping distance. Further context in this GH discussion.

Expected Behavior

Only nodes that are visible should be selectable by the user.

Current Behavior

The clipping distance is not perfectly respected which is why you can sometimes select nodes that are not rendered.

Steps to Reproduce the bug

  • Cannot reproduce the bug anymore / needs deeper investigation.
  1. create a node
  2. move in z by a few slices
  3. reduce the clipping distance so that it is not visible anymore
  4. click at the position where the node is in XY
  5. -> wk jumps to the clicked node even though it was invisible

Your Environment for bug

  • Browser name and version: e.g. Chrome 39
  • Operating System and version: e.g. Windows 10
  • Version of WEBKNOSSOS (Release or Commit):
  • Specific to long-running jobs (set jobsEnabled=true in application.conf)
  • Specific to webknossos.org (set isDemoInstance=true in application.conf)
@daniel-wer
Copy link
Member

Not sure if this is related, but I noticed that the clipping in oblique and flight mode changes when zooming. If the clipping distance were in nm (which it is supposed to be) this shouldn't happen.

@philippotto
Copy link
Member Author

@daniel-wer In #7732 you wrote that that PR contributes to this issue. What parts are still missing?

@daniel-wer
Copy link
Member

I wrote this, because my fix didn't explain this observation

Not sure if this is related, but I noticed that the clipping in oblique and flight mode changes when zooming. If the clipping distance were in nm (which it is supposed to be) this shouldn't happen.

However, I did a quick test again and although the clipping changed during zooming I wasn't able to select invisible nodes, so I guess this particular issue (mismatch between what's displayed and the node picking) is resolved. What remains to be investigated is why the clipping distance in oblique/flight mode changes during zooming and doesn't seem to be in nm.

@philippotto
Copy link
Member Author

Great, thanks for the clarification!

@philippotto philippotto changed the title Occasionally, invisible nodes can be selected Clipping distance changes with zoom in arbitrary mode Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants