Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag selection of annotations does not work with single letter tags #7629

Closed
1 task
erjel opened this issue Feb 15, 2024 · 2 comments · Fixed by #7640
Closed
1 task

Tag selection of annotations does not work with single letter tags #7629

erjel opened this issue Feb 15, 2024 · 2 comments · Fixed by #7640

Comments

@erjel
Copy link
Contributor

erjel commented Feb 15, 2024

Context

I tried to tag a couple of annotations in the annotation dashboard as quickly as possible. I decided to just use a single letter "t". When I now select this tag, I still see all annotations in the dashboard

Expected Behavior

I would expect that webknossos only shows the tagged annotations

Current Behavior

Webknossos shows a strange subset of all annotations. I need at least 3 characters "ttt" to see only the tagged annotations.

Your Environment for bug

  • Browser name and version: Firefox 122.0.1 (64-bit)
  • Operating System and version: Windows 10
  • Version of WEBKNOSSOS (Release or Commit): 24.02.0
  • Specific to webknossos.org (set isDemoInstance=true in application.conf)
@erjel erjel added the bug label Feb 15, 2024
@fm3 fm3 added the frontend label Feb 15, 2024
@fm3
Copy link
Member

fm3 commented Feb 15, 2024

Thanks for your report! I can confirm that something is off with filtering annotations by tags.

It looks like the selected tag is just appended to the search query and even if something other than the tag matches that (e.g. the user name), the annotation is displayed. So for single-letter tags, most annotations probably match that, since the letter is contained somewhere.

We’ll have a look into how this tag filtering can be adapted to actually filter only by the tags.

cc @philippotto

@philippotto
Copy link
Member

Thanks for the report! I opened a PR which will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants