Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply Target Folder when adding Remote Dataset #7215

Closed
fm3 opened this issue Jul 19, 2023 · 3 comments · Fixed by #7221
Closed

Supply Target Folder when adding Remote Dataset #7215

fm3 opened this issue Jul 19, 2023 · 3 comments · Fixed by #7221

Comments

@fm3
Copy link
Member

fm3 commented Jul 19, 2023

Starting in #7176 (still WIP as of this writing) the backend supports a folderId field for the add route called by the frontend in storeRemoteDataset. The frontend should use that (and show a folder selection menu just like in the upload view).

This way the normal folder rights management is also respected when storing remote datasets. Otherwise, the user can only add remote datasets when having write access to the root folder

Related: #7199

@fm3
Copy link
Member Author

fm3 commented Jul 20, 2023

Turns out the front-end calls updatePartial, setting the folder id, after hitting the add button. That should be removed in favor of passing the folderId to storeRemoteDataset (as introduced in #7176 in the backend)

@fm3
Copy link
Member Author

fm3 commented Jul 20, 2023

I extracted the relevant changes from #7176 to the new smaller PR #7221 to avoid this being blocked for so long. Could you add the front-end changes there?

@philippotto
Copy link
Member

Could you add the front-end changes there?

Done :)

@fm3 fm3 closed this as completed in #7221 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants