Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event change_tracing_layout is also sent when switching viewports #5574

Closed
philippotto opened this issue Jun 17, 2021 · 0 comments · Fixed by #5999
Closed

Event change_tracing_layout is also sent when switching viewports #5574

philippotto opened this issue Jun 17, 2021 · 0 comments · Fixed by #5999
Assignees

Comments

@philippotto
Copy link
Member

change_tracing_layout (in onLayoutChange in flex_layout_wrapper.js) should only be sent when the layout changes due to a user action (e.g., a tab is dragged somewhere or resizing is done). However, the event is also sent when I simply click into a viewport.

Reproduction:

  • open an annotation (I opened one in read-only mode). not sure whether this also works locally? maybe the events are not sent on localhost in the first place
  • click in different viewports
  • observe the network tab which should show the analytics events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants