Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple plane viewport camera updates from the 3D Camera controller. #5436

Open
MichaelBuessemeyer opened this issue Apr 29, 2021 · 0 comments

Comments

@MichaelBuessemeyer
Copy link
Contributor

Detailed Description

Currently, wk has only one active CameraController at a time that is the TdController. One of this controller's tasks is to update the camera of each viewport once they change. Thus, if the 3D Viewport was not rendered before the fix in #5429 the cameras were not updated and therefore no data was rendered.

To not have a bug like this again, I suggest taking away the task of updating the other viewport's cameras from the TdController and do this task somewhere else so that each viewport is responsible for updating its own camera.

Also see the following: reference.

Context

The suggestion to this change came up in PR #5429.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant