Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against corrupted settings #4751

Closed
philippotto opened this issue Aug 5, 2020 · 1 comment
Closed

Guard against corrupted settings #4751

philippotto opened this issue Aug 5, 2020 · 1 comment

Comments

@philippotto
Copy link
Member

There are multiple ways to do this:

  • enforce that the layer settings match our schema (e.g., if a layer opacity is none, change it to the default layer opacity)
  • catch react errors in the settings component and reset all settings to default

The case which we observed twice now is that the layer alpha value was set to null for some reason, causing wk to crash as soon as the settings sidebar was opened.

@philippotto
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant