Add an implementation of IsSeq for IArray. #24552
Open
+44
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of just casting the Array variant, the underlying collection type should be immutable.ArraySeq.
Contributor
|
Will this be part of Scala 2.13? or Scala 3 only? |
Contributor
|
Note: this will have to wait until Scala 3.10 due to the current feature freeze (tied to 3.9 LTS being cooked). |
Gedochao
added
the
stat:feature freeze
Contributor
|
@Gedochao Why not just create a new milestone 3.10.0 and add these to there, instead of a filter tag. |
Contributor
We'll be doing both. |
Member
Author
Its for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of just casting the Array variant, the underlying collection type should be immutable.ArraySeq.
fixes #24512