module classes can sometimes extend scala.runtime.AbstractFuntionN in Scala 2
#24147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Oct 8, 2025
| if Feature.shouldBehaveAsScala2 && !mods.is(Abstract) && originalTparams.isEmpty && arity <= MaxImplementedFunctionArity then | ||
| val tpt = originalVparamss.head.map(_.tpt) :+ untpd.Ident(cdef.name) | ||
| val parent = appliedTypeTree(scalaRuntimeDot(s"AbstractFunction$arity".toTypeName), tpt) | ||
| companionDefs(parent, applyMeths ::: unapplyMeth :: toStringMeth :: companionMembers) |
Member
There was a problem hiding this comment.
This is a change that library maintainers have had to make in user-space when upgrading from 2 to 3. We should do the same and change this in user-space.
Member
Author
|
After second thoughts and discussing with @sjrd, we will migrate these changes in user-space. |
hamzaremmal
force-pushed
the
module-class-scala2
branch
from
ac46e2b to
e7c79dc
Compare
sjrd
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from: https://github.com/scala/scala/blob/6ecf74bfb4e914391fda1df5288ebaad6e4699b8/src/compiler/scala/tools/nsc/typechecker/Unapplies.scala#L122
This is supposed to follow this part of the spec but the implementation is somehow different...