Workaround missing complitions due to non-backportable change in the upstream. Update CompletionTests

Author: WojciechMazur

language-server/test/dotty/tools/languageserver/CompletionTest.scala

@@ -1659,7 +1659,7 @@ class CompletionTest {
            |""".completion(m1, Set(
              ("Number", Field, "scala.util.matching.Regex"),
              ("NumberFormatException", Module, "NumberFormatException"),
-             ("Numeric", Field, "scala.math.Numeric")
+             ("Numeric", Method, "=> scala.math.Numeric.type")
            ))
 
   @Test def shadowedImportType: Unit =
@@ -1677,6 +1677,6 @@ class CompletionTest {
              ("NumberFormatException", Module, "NumberFormatException"),
              ("NumberFormatException", Field, "NumberFormatException"),
              ("Numeric", Field, "Numeric"),
-             ("Numeric", Field, "scala.math.Numeric")
+             ("Numeric", Method, "=> scala.math.Numeric.type")
            ))
 }

presentation-compiler/src/main/dotty/tools/pc/completions/Completions.scala

@@ -231,7 +231,14 @@ class Completions(
       label: String,
       toCompletionValue: (String, SingleDenotation, CompletionSuffix) => CompletionValue
   ): List[CompletionValue] =
-    val sym = denot.symbol
+    // Workaround for LTS due to lack of https://github.com/scala/scala3/pull/18874 backport
+    // required after backport of https://github.com/scala/scala3/pull/18914
+    // We use the symbol of accessor result type to make the sym compliant with the 3.4+
+    // where we would obtain the field symbol directly
+    val sym =
+      val resultTpeSym = denot.info.finalResultType.typeSymbol
+      if denot.symbol.is(Accessor) && resultTpeSym != NoSymbol then resultTpeSym
+      else denot.symbol
     // find the apply completion that would need a snippet
     val methodDenots: List[SingleDenotation] =
       if shouldAddSnippet && completionMode.is(Mode.Term) &&