Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation warnings ("object WixHelper is deprecated") #158

Closed
SethTisue opened this issue Jan 13, 2016 · 4 comments
Closed

deprecation warnings ("object WixHelper is deprecated") #158

SethTisue opened this issue Jan 13, 2016 · 4 comments

Comments

@SethTisue
Copy link
Member

since enabling -deprecation in compiling the build definition, we're seeing:

[warn] /Users/tisue/scala-dist/project/Wix.scala:35: method generateComponentsAndDirectoryXml in object WixHelper is deprecated: Use higher level abstraction
[warn]     val (bin, binDirXml0) = generateComponentsAndDirectoryXml(stage / "bin")
[warn]                             ^
[warn] /Users/tisue/scala-dist/project/Wix.scala:36: method generateComponentsAndDirectoryXml in object WixHelper is deprecated: Use higher level abstraction
[warn]     val (doc, docDirXml)  = generateComponentsAndDirectoryXml(stage / "doc", "doc_")
[warn]                             ^
[warn] /Users/tisue/scala-dist/project/Wix.scala:37: method generateComponentsAndDirectoryXml in object WixHelper is deprecated: Use higher level abstraction
[warn]     val (lib, libDirXml)  = generateComponentsAndDirectoryXml(stage / "lib")
[warn]                             ^
[warn] /Users/tisue/scala-dist/project/Wix.scala:38: method generateComponentsAndDirectoryXml in object WixHelper is deprecated: Use higher level abstraction
[warn]     val (api, apiDirXml)  = generateComponentsAndDirectoryXml(stageApi / "api", "api_")
[warn]                             ^

it would be nice to address this, because then we could enable -Xfatal-warnings for the build definition

@SethTisue
Copy link
Member Author

@muuki88 is this something you might be interested in addressing?

@muuki88
Copy link
Contributor

muuki88 commented Jan 14, 2016

Unfortunately I have no experience with the Windows stuff after all. The deprecation warning is pretty old though. @jsuereth introduced it almost 2 1/2 years ago. We can open an issue on sbt/sbt-native-packager and I can ping the two windows contributors if they have resources to fix this.

Other option is to remove the deprecation.

@SethTisue
Copy link
Member Author

I can ping the two windows contributors if they have resources to fix this

I'd appreciate that

@SethTisue
Copy link
Member Author

if sbt/sbt-native-packager#909 is merged, the warnings will go away when we eventually upgrade to that version, but it could be a while, as per #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants