Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of IOExceptions in the compiler #886

Open
retronym opened this issue Nov 17, 2020 · 0 comments
Open

Improve handling of IOExceptions in the compiler #886

retronym opened this issue Nov 17, 2020 · 0 comments

Comments

@retronym
Copy link
Member

  • Avoid globalError(ex.getMessage) in compileFiles unless for some reason we're sure the exception message is sufficient for a particular exception. That would be better to deal with by introducing a new custom exception for "message only" failures and throwing that from very particular spots.

  • Be more selective about when to report an encoding error in SourceReader.read.

scalac DoesNotExist.scala
error: IO error while decoding DoesNotExist.scala with UTF-8: DoesNotExist.scala (No such file or directory)
Please try specifying another one using the -encoding option
1 error
@retronym retronym added this to the 2.12.14 milestone Nov 17, 2020
@retronym retronym self-assigned this Nov 17, 2020
@SethTisue SethTisue modified the milestones: 2.12.14, 2.12.15 May 18, 2021
@SethTisue SethTisue modified the milestones: 2.12.15, 2.12.16 Aug 31, 2021
@SethTisue SethTisue modified the milestones: 2.12.16, Backlog Apr 25, 2022
@SethTisue SethTisue transferred this issue from scala/bug Dec 10, 2024
@SethTisue SethTisue removed this from the Backlog milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants