Multivar definitions get transparent positions [ci: last-only] #10991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/13067-multidef-pos
branch
from
c2b6ba8 to
7e8fd1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#13067
In
var x, y: Int = 42, the trees span the text, with point at the name. The symbol pos is the name pos.In
patDefOrDecl,mkDefsis refactored for clarity; the recursion inexpandPatDefsis easier to read.NamePoshandling is pushed intomakePatDef, resulting in better positions, reflected in updated check files. (A few warnings are now hidden by errors at the same position.)In the multivar def, only
y: Intmay be an opaque position. (That nuance is probably not relevant.) Otherwise, the spans of the trees are transparent.The test shows the
valdef.namePosandvaldef.posfor various single and multi defs.