-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate empty hardhat_contract.ts file on postinstall #260
Conversation
Your approach of generating an empty record as sort of 'default' contracts file gave me some more ideas to try out. I pushed a commit to your branch, it seems to be working nicely now, and I believe this is exactly what we wanted to have (the project being in a compilable state after just running I even managed to remove the contracts import from the scaffold.config, this pass-through is obsolete with this solution. I also moved the The only thing that I didn't get to work was the |
Did some digging and I think Yarn has some issues, it only runs I tried doing a fresh clone of the repo and ran |
This looks great @sverps Thank you! There is only one thing left The tweak I made for the Faucet & the autoconnect don't work, since a) I did a in 9913f5b, but if the types b are easily fixable, happy to switch.
Yep, also noticed this. In our case, I think we don't mind... since it'll be generated on a fresh clone. |
Merging this since we are about to announce the SE-2 hackathon, and want this to be in :) We can rethink some stuff later. |
Just tinkering around. This PR might end on the trash :D
Since we merged #255 I was thinking about how we could improve it. I was thinking about generating an «empty» "hardhat_contracts.ts" file on
yarn install
.This is a quick & dirty attempt to do so.
Does this make sense? I have some issues with
contract.types.ts
and am not sure if there is a workaround (is it breaking the narrow typing?)cc @sverps