Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor neural_nets module #1190

Closed
janfb opened this issue Jul 9, 2024 · 1 comment
Closed

refactor neural_nets module #1190

janfb opened this issue Jul 9, 2024 · 1 comment
Labels
architecture Internal changes without API consequences
Milestone
Hackathon and rel...

Comments

@janfb
Copy link
Contributor

janfb commented Jul 9, 2024

The sbi/neural_nets is a bit of a mess:

  • it has embedding networks, ratio estimators, all kind of build functions on the top level
  • and a submodule density_estimators containing the ConditionalEstimator base class (which is not really a density estimator) and the corresponding flow-based ConditionalDensityEstimator classes.

Suggested fix: group the modules into helper functions / build functions vs. neural networks / classes implementing estimators vs utils.
@janfb janfb added the architecture Internal changes without API consequences label Jul 9, 2024
@janfb janfb mentioned this issue Jul 9, 2024
Closed
@janfb
Copy link
Contributor Author

janfb commented Aug 6, 2024

duplicate of #991

@janfb janfb added this to the Hackathon and release 2024 milestone Aug 6, 2024
@gmoss13 gmoss13 mentioned this issue Aug 13, 2024
Merged
@janfb janfb closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture Internal changes without API consequences
Projects
None yet
Milestone
Hackathon and release 0.23
Development

No branches or pull requests
1 participant
@janfb